----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197383 -----------------------------------------------------------
Ship it! Would be great to see some TODOs or a ticket to clean up the confusion around StartSlave not starting the slave when mock=true. - Benjamin Mahler On Feb. 12, 2018, 7:48 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65497/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2018, 7:48 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8411 > https://issues.apache.org/jira/browse/MESOS-8411 > > > Repository: mesos > > > Description > ------- > > This test verifies that the v1 executor is shutdown if all of its > initial tasks could not be delivered when re-subscribing with > a recovered agent. See MESOS-8411. > > > Diffs > ----- > > src/tests/mesos.hpp c5593c25dde18c005f195a1885a8586bc72c849f > src/tests/mesos.cpp ac789297d6aa034121b73e4efc0aafee1ee3b60f > src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 > > > Diff: https://reviews.apache.org/r/65497/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
