-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65705/#review197752
-----------------------------------------------------------


Ship it!





src/python/cli_new/bootstrap
Line 27 (original), 27 (patched)
<https://reviews.apache.org/r/65705/#comment278035>

    Maybe not an issue for this patch, but couldn't we just `deactivate` from 
the script here instead of stopping? We already know that virtualenvs cannot be 
nested.


- Benjamin Bannier


On Feb. 18, 2018, 4:14 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65705/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2018, 4:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the absolute path to the Python interpreter is long, it may exceed
> the maximum length allowed for a shebang line (limit set to 128 on many
> Linux distributions). When the shebang length limit is exceeded, pip
> fails with the error: "bad interpreter: No such file or directory".
> 
> A work-around for this problem is to run the pip library module which is
> what we do in this patch. This will also be done to use PyInstaller.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a 
> 
> 
> Diff: https://reviews.apache.org/r/65705/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on internal CI.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Reply via email to