----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65696/#review197809 -----------------------------------------------------------
Ship it! 3rdparty/stout/include/stout/base64.hpp Line 92 (original), 92 (patched) <https://reviews.apache.org/r/65696/#comment278087> Can we add a leading comment on which exact variants of the most recent RFC we now support with all of our options here? Maybe reference the whitespace handling advices from the RFC to make sure people can validate - either comment or commit description. - Till Toenshoff On Feb. 17, 2018, 12:27 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65696/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2018, 12:27 a.m.) > > > Review request for mesos, Michael Park and Till Toenshoff. > > > Bugs: MESOS-8569 > https://issues.apache.org/jira/browse/MESOS-8569 > > > Repository: mesos > > > Description > ------- > > Most base64 decoders do not fail on encountering whitespace characters > as several encoders embed newlines to enforce line-width in encoded > data. > > > Diffs > ----- > > 3rdparty/stout/include/stout/base64.hpp > eabc9b0f0ad794ffccda44e338ea855b8c4a796f > 3rdparty/stout/tests/base64_tests.cpp > a6837c820384e3311d2c030885039a7dd7f01a66 > > > Diff: https://reviews.apache.org/r/65696/diff/3/ > > > Testing > ------- > > Updated base64 tests and ran make check > > > Thanks, > > Kapil Arya > >
