-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64387/
-----------------------------------------------------------

(Updated Feb. 22, 2018, 11:18 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, Jie Yu, Joseph Wu, and Michael Park.


Changes
-------

Addressed Alex's feedback.


Bugs: MESOS-8498
    https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
-------

The `HealthCheckTest.ROOT_DOCKER_*` and
`DockerContainerizerHealthCheckTest.*` tests now work on Windows.


Diffs (updated)
-----

  src/tests/containerizer/docker_common.hpp PRE-CREATION 
  src/tests/environment.cpp e1aa020f53dfce03261234edf15553c087b4edff 
  src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab 


Diff: https://reviews.apache.org/r/64387/diff/14/

Changes: https://reviews.apache.org/r/64387/diff/13-14/


Testing
-------

Windows Server:
[==========] Running 5 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 2 tests from HealthCheckTest
[ RUN      ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
[       OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask (21263 ms)
[ RUN      ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
[       OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange (23512 ms)
[----------] 2 tests from HealthCheckTest (44835 ms total)

[----------] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest
[ RUN      ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
[       OK ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
 (28487 ms)
[ RUN      ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
[       OK ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
 (26447 ms)
[ RUN      ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
[       OK ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
 (26264 ms)
[----------] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest 
(81268 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 2 test cases ran. (126559 ms total)
[  PASSED  ] 5 tests

Rest of tests pass.

Windows Client (Disabled network health checks):
Proof that network health checks are skipped on Windows Client.
C:\Program Files\Docker\Docker\Resources\bin\docker.exe: Error response from 
daemon: sharing of hyperv containers network is not supported.
356b087e7fa640f83fe27ebeb3396bfc7b2bbebd917aeaec0508b887b41d31f4
-------------------------------------------------------------
We cannot run any Docker health checks tests because:
Running in another container's namespace is not supported on this version of 
Windows.

Rest rests pass.

Linux:
make check passes


Thanks,

Akash Gupta

Reply via email to