-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64387/
-----------------------------------------------------------
(Updated Jan. 30, 2018, 10:21 a.m.)
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston
Kleiman, Jie Yu, Joseph Wu, and Michael Park.
Changes
-------
Removed `errorString` in `launchAndWaitContainer`
Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498
Repository: mesos
Description
-------
The `HealthCheckTest.ROOT_DOCKER_*` and
`DockerContainerizerHealthCheckTest.*` tests now work on Windows.
Diffs (updated)
-----
src/tests/environment.cpp 13a4c9514fcd3016fe623c597decd067457e86cd
src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
src/tests/mesos.hpp a35c68e8645384f6244d17e37cad71373aba6893
Diff: https://reviews.apache.org/r/64387/diff/10/
Changes: https://reviews.apache.org/r/64387/diff/9-10/
Testing
-------
Windows Server:
[==========] Running 5 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 2 tests from HealthCheckTest
[ RUN ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
[ OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask (21263 ms)
[ RUN ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
[ OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange (23512 ms)
[----------] 2 tests from HealthCheckTest (44835 ms total)
[----------] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest
[ RUN ]
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
[ OK ]
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
(28487 ms)
[ RUN ]
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
[ OK ]
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
(26447 ms)
[ RUN ]
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
[ OK ]
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
(26264 ms)
[----------] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest
(81268 ms total)
[----------] Global test environment tear-down
[==========] 5 tests from 2 test cases ran. (126559 ms total)
[ PASSED ] 5 tests
Rest of tests pass.
Windows Client (Disabled network health checks):
Proof that network health checks are skipped on Windows Client.
C:\Program Files\Docker\Docker\Resources\bin\docker.exe: Error response from
daemon: sharing of hyperv containers network is not supported.
356b087e7fa640f83fe27ebeb3396bfc7b2bbebd917aeaec0508b887b41d31f4
-------------------------------------------------------------
We cannot run any Docker health checks tests because:
Running in another container's namespace is not supported on this version of
Windows.
Rest rests pass.
Linux:
make check passes
Thanks,
Akash Gupta
