----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review198171 -----------------------------------------------------------
Patch looks great! Reviews applied: [64970] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 23, 2018, 7:58 a.m., Eric Chung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64970/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2018, 7:58 a.m.) > > > Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Use tox for linting and testing code living uder src/python. > > At the moment, all linting is done through the same `pylint` > installation under support/.virtualenv, which requires ALL dependencies > (i.e. pip-requirements.txt, requirements.in scattered in various > directories) to be installed in the same virtualenv, making things > really messy -- e.g. when I've changed some code under `src/python/lib`, > but don't have the dev virtualenv activated, linting will fail since > none of the dependencies under `src/python/lib` have been installed. > > Using tox, we can solve this problem by distributing a "test spec" > (tox.ini) in each of the python source directories which are aware of > its local dependencies only. To test or lint the code there would be as > simple as running `tox -e py27-lint <file_path>`, and the corresponding > virtualenv and test dependencies would automatically be setup. > > This patch modifies `support/mesos-style.py` to install `tox` in > `support/.virtualenv` and delegates linting to a `tox` call when it sees > python directories that have tox setup for it. Linting for all other > languages will not be effected. > > Testing Done: > 1. intentionally create a lint error, such as extra spaces before a > parens in a python file > 2. run the pre-commit hook and see tox in action > > Reviewed at https://reviews.apache.org/r/64970/ > > > Diffs > ----- > > src/python/cli_new/tox.ini PRE-CREATION > src/python/lib/requirements-test.in > b2b73aab65377d9310797203ea84c5150ae60805 > src/python/lib/tox.ini fd5e89c77c8608fea21e9caad814c6e111ad57db > support/mesos-style.py 47ec36949010fa511d1b3974739c5ad5c03f6f7f > > > Diff: https://reviews.apache.org/r/64970/diff/4/ > > > Testing > ------- > > 1. intentionally create a lint error, such as extra spaces before a parens in > a python file > 2. run the pre-commit hook and see tox in action > > > Thanks, > > Eric Chung > >
