----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65661/#review198309 -----------------------------------------------------------
Patch looks great! Reviews applied: [65661] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 15, 2018, 10:42 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65661/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2018, 10:42 p.m.) > > > Review request for mesos, Benjamin Mahler, Kapil Arya, Joseph Wu, Michael > Park, and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > We currently do not differentiate between quota guarantee and limit > i.e. quota currently is set for both guarantee and limit. As a > first step to introduce quota limit, comments and related variable > names are updated to reflect the difference between quota guarantee > and limit. > > Also fixed a few typos and removed some outdated comments. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 37d2df58d374f118697fb5848c36f78b3e65128d > src/master/allocator/mesos/hierarchical.cpp > 80e0a347d6641c922cf7c62bef220ff5c8864597 > > > Diff: https://reviews.apache.org/r/65661/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
