----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65661/#review198306 -----------------------------------------------------------
Fix it, then Ship it! src/master/allocator/mesos/hierarchical.hpp Lines 476-480 (original), 477-481 (patched) <https://reviews.apache.org/r/65661/#comment278894> Probably this is clearer? ``` // There are two stages of allocation: // // Stage 1: Allocate to satisfy quota guarantees. // // Stage 2: Allocate above quota guarantees up to quota limits. // Note that we need to hold back enough "headroom" // to ensure that any unsatisfied quota can be // satisfied later. ``` src/master/allocator/mesos/hierarchical.hpp Lines 479-480 (original), 480-481 (patched) <https://reviews.apache.org/r/65661/#comment278429> "are then allocated to roles above their guarantee but below their limit." src/master/allocator/mesos/hierarchical.hpp Line 513 (original), 514 (patched) <https://reviews.apache.org/r/65661/#comment278430> is set to a non-default value src/master/allocator/mesos/hierarchical.cpp Line 1559 (original), 1559 (patched) <https://reviews.apache.org/r/65661/#comment278899> a role with non-default quota src/master/allocator/mesos/hierarchical.cpp Line 1562 (original), 1562 (patched) <https://reviews.apache.org/r/65661/#comment278900> quota guarantee src/master/allocator/mesos/hierarchical.cpp Line 1564 (original), 1564 (patched) <https://reviews.apache.org/r/65661/#comment278901> quota guarantee src/master/allocator/mesos/hierarchical.cpp Line 1577 (original), 1577 (patched) <https://reviews.apache.org/r/65661/#comment278897> with a non-default quota src/master/allocator/mesos/hierarchical.cpp Line 1623 (original), 1624 (patched) <https://reviews.apache.org/r/65661/#comment278902> s/quota// src/master/allocator/mesos/hierarchical.cpp Line 1625 (original), 1626 (patched) <https://reviews.apache.org/r/65661/#comment278903> quota guarantee src/master/allocator/mesos/hierarchical.cpp Line 1636 (original), 1637 (patched) <https://reviews.apache.org/r/65661/#comment278904> quota guarantee src/master/allocator/mesos/hierarchical.cpp Lines 1734-1735 (patched) <https://reviews.apache.org/r/65661/#comment278905> What's this about? src/master/allocator/mesos/hierarchical.cpp Line 1854 (original), 1864 (patched) <https://reviews.apache.org/r/65661/#comment278906> I don't think we needed to change this? Technically it counts towards "quota" which includes guarantee *and* limit? src/master/allocator/mesos/hierarchical.cpp Line 1987 (original), 1993 (patched) <https://reviews.apache.org/r/65661/#comment278908> quota guarantee headroom - Benjamin Mahler On Feb. 15, 2018, 10:42 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65661/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2018, 10:42 p.m.) > > > Review request for mesos, Benjamin Mahler, Kapil Arya, Joseph Wu, Michael > Park, and Till Toenshoff. > > > Bugs: MESOS-8456 > https://issues.apache.org/jira/browse/MESOS-8456 > > > Repository: mesos > > > Description > ------- > > We currently do not differentiate between quota guarantee and limit > i.e. quota currently is set for both guarantee and limit. As a > first step to introduce quota limit, comments and related variable > names are updated to reflect the difference between quota guarantee > and limit. > > Also fixed a few typos and removed some outdated comments. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 37d2df58d374f118697fb5848c36f78b3e65128d > src/master/allocator/mesos/hierarchical.cpp > 58aa83ffdb194bbb9bb518a6b77e23fa49d340f4 > > > Diff: https://reviews.apache.org/r/65661/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
