-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65692/#review198667
-----------------------------------------------------------



I suppose it's lucky that `Owned` is implemented with `shared_ptr`, otherwise, 
we'd be double-freeing most of these.


src/launcher/default_executor.cpp
Line 986 (original), 986 (patched)
<https://reviews.apache.org/r/65692/#comment278911>

    Here's another copy that should be made into a reference.



src/launcher/default_executor.cpp
Lines 1074-1076 (original), 1074-1076 (patched)
<https://reviews.apache.org/r/65692/#comment279075>

    As an alternative, you could change this to take a `Owned<Container>&` 
instead.


- Joseph Wu


On Feb. 16, 2018, 4:24 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65692/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2018, 4:24 p.m.)
> 
> 
> Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8530
>     https://issues.apache.org/jira/browse/MESOS-8530
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This method is being passed the container to be killed as
> `Owned<Container>`.
> 
> The container object is owned by the executor and stored in
> `LinkedHashMap<TaskID, Owner<Container>> containers`.
> 
> We should pass around raw pointers and not make copies of the stored
> `Owned` object, so this patch changes the signature of the `kill`
> method.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 8720dada8bc6ca66f9e0fec6dc265eda3dcc7407 
> 
> 
> Diff: https://reviews.apache.org/r/65692/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Reply via email to