----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65693/#review198670 -----------------------------------------------------------
What-is-basically-a-style-nit: src/launcher/default_executor.cpp Lines 1172-1176 (original), 1174-1183 (patched) <https://reviews.apache.org/r/65693/#comment278914> If you start the lambda with: ``` [=](const Response& response) -> Future<Nothing> ``` Then you won't need to wrap the two return statements with `Future<Nothing>(...)`. - Joseph Wu On Feb. 16, 2018, 4:25 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65693/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2018, 4:25 p.m.) > > > Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-8530 > https://issues.apache.org/jira/browse/MESOS-8530 > > > Repository: mesos > > > Description > ------- > > The default executor's `Future<Nothing> kill(const ContainerID&, int)` > method returns `Nothing()` if the agent responded to the > `KILL_NESTED_CONTAINER` call, regardless of the response. > > This patch updates the method, so that it returns a failure if the > response is not "200 OK". > > > Diffs > ----- > > src/launcher/default_executor.cpp 8720dada8bc6ca66f9e0fec6dc265eda3dcc7407 > > > Diff: https://reviews.apache.org/r/65693/diff/1/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
