----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65694/#review198833 -----------------------------------------------------------
Ship it! LGTM. Note to self: `s/it/executor/` in the commit description. - Joseph Wu On Feb. 16, 2018, 4:30 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65694/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2018, 4:30 p.m.) > > > Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-8530 > https://issues.apache.org/jira/browse/MESOS-8530 > > > Repository: mesos > > > Description > ------- > > This patch makes the default executor retry SIGKILL escalations if the > it is disconnected from the agent or the kill call fails. > > > Diffs > ----- > > src/launcher/default_executor.cpp 8720dada8bc6ca66f9e0fec6dc265eda3dcc7407 > > > Diff: https://reviews.apache.org/r/65694/diff/1/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
