----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66010/ -----------------------------------------------------------
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park. Repository: mesos Description ------- We previously attempted to manually override the CRT to be static everywhere. Not only did this emit warnings, it was also error-prone and unnecessary. We can, and should, just use the defaults, which is `/MDd` in debug mode (multi-threaded, dynamic, debug linkage). Linking to the CRT dynamically results in smaller libraries and executables, reduces linking time, and avoids bugs when sharing allocated memory across modules. Diffs ----- cmake/CompilationConfigure.cmake efee36c1ffda096a97af23d481fc0d0903124e54 Diff: https://reviews.apache.org/r/66010/diff/1/ Testing ------- Thanks, Andrew Schwartzmeyer
