This is an automatically generated e-mail. To reply, visit:

(Updated March 13, 2018, 1:45 p.m.)

Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John 
Kordich, Joseph Wu, and Michael Park.

Bugs: MESOS-8659

Repository: mesos


We previously attempted to manually override the CRT to be static
everywhere. Not only did this emit warnings, it was also error-prone
and unnecessary. We can, and should, just use the defaults, which is
`/MDd` in debug mode (multi-threaded, dynamic, debug linkage). Linking
to the CRT dynamically results in smaller libraries and executables,
reduces linking time, and avoids bugs when sharing allocated memory
across modules.


  cmake/CompilationConfigure.cmake efee36c1ffda096a97af23d481fc0d0903124e54 

Diff: https://reviews.apache.org/r/66010/diff/1/

Testing (updated)

NOTE: I checked with Alex Ionescu and since we are deploying on the same OS 
versions as we're targetting, we don't need to worry about redistributing the 

If/when we start deploying on older OS versions, we can simply add instructions 
on installing the correct CRT redistributable (or make it part of the eventual 


Andrew Schwartzmeyer

Reply via email to