----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66012/#review199032 -----------------------------------------------------------
Ship it! I'm fine with these changes, but the description can be improved a bit I think. I know that this change relates to some of the later patches, so maybe mention that several of the fixes are built on top of this one (I guess that's implied, though). Maybe mention that this allows for granularity between C/CPP cmake flags, even though it's rather clear from the code. - John Kordich On March 9, 2018, 10:39 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66012/ > ----------------------------------------------------------- > > (Updated March 9, 2018, 10:39 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John > Kordich, Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > By passing `CMAKE_C_FORWARD_ARGS` to C libraries, e.g. curl, libapr, > libevent, and zlib, we avoid CMake warning us about set but unused > variables (since they do not use the `CXX` variables). > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191 > > > Diff: https://reviews.apache.org/r/66012/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
