----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66012/#review199181 -----------------------------------------------------------
Are we sure that this does not break other flags we forwarded to external projects? We seem to go from forwarding an open set of flags to only forwarding flags related to `C` and `CXX`. I am thinking e.g., about `CMAKE_GENERATOR`, see https://github.com/apache/mesos/blob/master/3rdparty/CMakeLists.txt#L101-L102 # TODO(andschwa): Set the CMAKE_GENERATOR explicitly as an argmuent to # `ExternalProject_Add`. but I could imagine this change to affect other areas as well. Or do I completely misunderstand this change? - Benjamin Bannier On March 9, 2018, 11:39 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66012/ > ----------------------------------------------------------- > > (Updated March 9, 2018, 11:39 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John > Kordich, Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > By passing `CMAKE_C_FORWARD_ARGS` to C libraries, e.g. curl, libapr, > libevent, and zlib, we avoid CMake warning us about set but unused > variables (since they do not use the `CXX` variables). > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191 > > > Diff: https://reviews.apache.org/r/66012/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
