----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66026/#review199051 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/tests/protobuf_tests.cpp Line 108 (original), 108 (patched) <https://reviews.apache.org/r/66026/#comment279346> Would you mind using the C++-style string literals to avoid the escaping, like we do here? https://github.com/apache/mesos/blob/master/src/tests/storage_local_resource_provider_tests.cpp#L178 It would introduce inconsistency between this test and the remaining tests in this file. So it's fine if you don't want to do this. 3rdparty/stout/tests/protobuf_tests.cpp Lines 141 (patched) <https://reviews.apache.org/r/66026/#comment279348> Maybe `s/_expected/accepted/` to avoid naming confusion since we aren't expecting something equals to this string? 3rdparty/stout/tests/protobuf_tests.cpp Lines 145-156 (patched) <https://reviews.apache.org/r/66026/#comment279347> We probably want to make `d`, `f`, `repeated_double` and `repeated_float` strings as well. - Chun-Hung Hsiao On March 12, 2018, 1:30 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66026/ > ----------------------------------------------------------- > > (Updated March 12, 2018, 1:30 a.m.) > > > Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. > > > Bugs: MESOS-8656 > https://issues.apache.org/jira/browse/MESOS-8656 > > > Repository: mesos > > > Description > ------- > > Updated `ProtobufTest.JSON` for parsing JSON::String to bools&integers. > > > Diffs > ----- > > 3rdparty/stout/tests/protobuf_tests.cpp > be35ad0d1e16501df67752a1818f79751419a43d > > > Diff: https://reviews.apache.org/r/66026/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
