> On March 13, 2018, 9:41 a.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/tests/protobuf_tests.cpp > > Line 108 (original), 108 (patched) > > <https://reviews.apache.org/r/66026/diff/1/?file=1973650#file1973650line108> > > > > Would you mind using the C++-style string literals to avoid the > > escaping, like we do here? > > https://github.com/apache/mesos/blob/master/src/tests/storage_local_resource_provider_tests.cpp#L178 > > > > It would introduce inconsistency between this test and the remaining > > tests in this file. So it's fine if you don't want to do this.
BenM raised a similar comment in this patch: https://reviews.apache.org/r/59989/. And yes, I agree we should do that, I will post a separate patch to do that for all the tests in this file. > On March 13, 2018, 9:41 a.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/tests/protobuf_tests.cpp > > Lines 141 (patched) > > <https://reviews.apache.org/r/66026/diff/1/?file=1973650#file1973650line141> > > > > Maybe `s/_expected/accepted/` to avoid naming confusion since we aren't > > expecting something equals to this string? Agree. > On March 13, 2018, 9:41 a.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/tests/protobuf_tests.cpp > > Lines 145-156 (patched) > > <https://reviews.apache.org/r/66026/diff/1/?file=1973650#file1973650line145> > > > > We probably want to make `d`, `f`, `repeated_double` and > > `repeated_float` strings as well. Yes! And also `optional_default`. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66026/#review199051 ----------------------------------------------------------- On March 12, 2018, 9:30 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66026/ > ----------------------------------------------------------- > > (Updated March 12, 2018, 9:30 a.m.) > > > Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. > > > Bugs: MESOS-8656 > https://issues.apache.org/jira/browse/MESOS-8656 > > > Repository: mesos > > > Description > ------- > > Updated `ProtobufTest.JSON` for parsing JSON::String to bools&integers. > > > Diffs > ----- > > 3rdparty/stout/tests/protobuf_tests.cpp > be35ad0d1e16501df67752a1818f79751419a43d > > > Diff: https://reviews.apache.org/r/66026/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
