-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66015/#review199106
-----------------------------------------------------------




3rdparty/CMakeLists.txt
Lines 260 (patched)
<https://reviews.apache.org/r/66015/#comment279396>

    Nit: a few more `###` :)



src/CMakeLists.txt
Lines 31-32 (patched)
<https://reviews.apache.org/r/66015/#comment279399>

    But also the prior directories too; hence why I think these two functions 
may be combined with a `SPEC` option or something to `PROTOC_GENERATE`.


- Andrew Schwartzmeyer


On March 9, 2018, 2:45 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66015/
> -----------------------------------------------------------
> 
> (Updated March 9, 2018, 2:45 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8657
>     https://issues.apache.org/jira/browse/MESOS-8657
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Built CSI spec proto files with cmake.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191 
>   3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d 
>   src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef 
> 
> 
> Diff: https://reviews.apache.org/r/66015/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` with cmake.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Reply via email to