----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66015/#review199225 -----------------------------------------------------------
Ship it! Nit on the commit message: `s/cmake/CMake/g` - Andrew Schwartzmeyer On March 13, 2018, 7:57 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66015/ > ----------------------------------------------------------- > > (Updated March 13, 2018, 7:57 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-8657 > https://issues.apache.org/jira/browse/MESOS-8657 > > > Repository: mesos > > > Description > ------- > > Built CSI spec proto files with cmake. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191 > 3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d > src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef > > > Diff: https://reviews.apache.org/r/66015/diff/2/ > > > Testing > ------- > > `make check` with cmake. > > > Thanks, > > Chun-Hung Hsiao > >
