----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65954/#review199195 -----------------------------------------------------------
Fix it, then Ship it! Nit: When you commit, can you s/Add/Added/ in the commit subject? src/slave/metrics.cpp Lines 254 (patched) <https://reviews.apache.org/r/65954/#comment279489> Nit: ``` CHECK_NONE(recovery_time_secs); ``` - James Peach On March 14, 2018, 4:06 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65954/ > ----------------------------------------------------------- > > (Updated March 14, 2018, 4:06 p.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Jason Lai, and James Peach. > > > Bugs: MESOS-8609 > https://issues.apache.org/jira/browse/MESOS-8609 > > > Repository: mesos > > > Description > ------- > > The new metric `slave/recover_time_secs` can be used to tell us how long > Mesos agent needed to finish its recovery cycle. This is an important > metric on agent machines which have a lot of completed executor > sandboxes. > > Note that the metric 1) will only be available after recovery succeeded > and 2) never change its value across agent process lifecycle afterwards. > > > Diffs > ----- > > src/slave/metrics.hpp 3fc933ca65690d6fad63156398ad9c2c53789296 > src/slave/metrics.cpp 0eb2b59ed67e14e73b29d7592c239441df0008d5 > src/slave/slave.cpp 2f4ab157448eafc0f41372ee50255a76129e90db > > > Diff: https://reviews.apache.org/r/65954/diff/4/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
