-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66046/
-----------------------------------------------------------
(Updated March 14, 2018, 4:18 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John
Kordich, Joseph Wu, and Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-8556
https://issues.apache.org/jira/browse/MESOS-8556
Repository: mesos
Description
-------
On Windows, Boost explicitly checks if it's being compiled with a
compiler version they've tested. As we tend to update Visual Studio
whenever a stable update is available, this leads to a Boost warning,
"Unknown compiler version..." being emitted repeatedly (for every file
which includes a Boost header).
If it were emitted once, we would leave it be, but because it's
repeated hundreds of times, and is mostly harmless, we patch the build
to remove the warning itself. Unfortunately, there is no compile-time
option to disable the warning instead of a patch.
Note that it is not straight-forward to generate a patch file for
Boost. The steps were: clone the Boost repo recursively, go the
`libs/config` submodule, edit the `visualc.hpp` file, go to the
`include` subdirectory, and use `git diff --relative` to generate the
patch with the corrects paths expected for the extracted tarball.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
3rdparty/boost-1.65.0.patch PRE-CREATION
Diff: https://reviews.apache.org/r/66046/diff/2/
Changes: https://reviews.apache.org/r/66046/diff/1-2/
Testing
-------
Built on Windows; no more warning.
Thanks,
Andrew Schwartzmeyer
