> On March 14, 2018, 6:44 p.m., Andrew Schwartzmeyer wrote: > > So, this patch is fairly temporary. The tip of `master` of Boost (of that > > submodule) has this commit: > > > > ``` > > commit 5ad073063 (origin/develop, origin/HEAD, develop) > > Author: jzmaddock <[email protected]> > > Date: Wed Mar 7 18:02:01 2018 +0000 > > > > visualc.hpp: Disable warning about outdated config. > > > > diff --git a/include/boost/config/compiler/visualc.hpp > > b/include/boost/config/compiler/visualc.hpp > > index 748d14076..c533c50df 100644 > > --- a/include/boost/config/compiler/visualc.hpp > > +++ b/include/boost/config/compiler/visualc.hpp > > @@ -346,6 +346,9 @@ > > # if defined(BOOST_ASSERT_CONFIG) > > # error "Boost.Config is older than your current compiler version." > > # elif !defined(BOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE) > > - BOOST_PRAGMA_MESSAGE("Info: Boost.Config is older than your compiler > > version - probably nothing bad will happen - but you may wish to look for > > an updated Boost vers > > ion. Define BOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE to suppress this > > message.") > > + // > > + // Disabled as of March 2018 - the pace of VS releases is hard to > > keep up with > > + // and in any case, we have relatively few defect macros defined now. > > + // BOOST_PRAGMA_MESSAGE("Info: Boost.Config is older than your > > compiler version - probably nothing bad will happen - but you may wish to > > look for an updated Boost v > > ersion. Define BOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE to suppress this > > message.") > > # endif > > #endif > > ``` > > > > So when we get an updated version of Boost with this change, we can just > > add `BOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE` to the pre-processor > > definitions and delete this patch. But it is necessary for now (and even > > upstream they realized this code was awful).
With this in mind, I'm fine with the patch. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66046/#review199198 ----------------------------------------------------------- On March 13, 2018, 10:30 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66046/ > ----------------------------------------------------------- > > (Updated March 13, 2018, 10:30 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John > Kordich, Joseph Wu, and Michael Park. > > > Bugs: MESOS-8556 > https://issues.apache.org/jira/browse/MESOS-8556 > > > Repository: mesos > > > Description > ------- > > On Windows, Boost explicitly checks if it's being compiled with a > compiler version they've tested. As we tend to update Visual Studio > whenever a stable update is available, this leads to a Boost warning, > "Unknown compiler version..." being emitted repeatedly (for every file > which includes a Boost header). > > If it were emitted once, we would leave it be, but because it's > repeated hundreds of times, and is mostly harmless, we patch the build > to remove the warning itself. Unfortunately, there is no compile-time > option to disable the warning instead of a patch. > > Note that it is not straight-forward to generate a patch file for > Boost. The steps were: clone the Boost repo recursively, go the > `libs/config` submodule, edit the `visualc.hpp` file, go to the > `include` subdirectory, and use `git diff --relative` to generate the > patch with the corrects paths expected for the extracted tarball. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191 > 3rdparty/boost-1.65.0.patch PRE-CREATION > > > Diff: https://reviews.apache.org/r/66046/diff/1/ > > > Testing > ------- > > Built on Windows; no more warning. > > > Thanks, > > Andrew Schwartzmeyer > >
