----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review199282 -----------------------------------------------------------
src/master/master.cpp Line 2138 (original), 2136 (patched) <https://reviews.apache.org/r/65571/#comment279587> Since we now also log in case of `None`, let's say something like "Conceded leadership to another master... committing suicide!" src/master/master.cpp Lines 2170 (patched) <https://reviews.apache.org/r/65571/#comment279585> I would say "Lost leadership..." here in order to avoid hinting there might be a new leader. src/master/master.cpp Lines 2173 (patched) <https://reviews.apache.org/r/65571/#comment279586> Let's move this log line higher up before `if (wasElected) {` and remove the "Retrying..." part. - Alexander Rukletsov On March 15, 2018, 2:19 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65571/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 2:19 p.m.) > > > Review request for mesos, Andrei Budnik and Alexander Rukletsov. > > > Bugs: MESOS-8550 > https://issues.apache.org/jira/browse/MESOS-8550 > > > Repository: mesos > > > Description > ------- > > The function `MasterDetector::detect()` returns a value of type > `Future<Option<MasterInfo>>`, which, according to its documentation, > can be `None` if an election occured and no master is elected. > > However, the code in `Master::detected()` was only handling the > cases of a failed future or a valid `MasterInfo` object. > > *NOTE*: This commit does not add a corresponding unit test, since > that would require starting a non-leading master. For the > ZooKeeperMasterDetector, this is blocked by MESOS-2976, and an API > change to make this possible with the StandaloneMasterDetector > would add a lot of complexity to the `cluster::Master::start()` > function for a feature that is unlikely to be re-used in any other > test. > > > Diffs > ----- > > src/master/master.cpp f0affa09dcf41b6a800e18105ad047bcffdfd3ec > > > Diff: https://reviews.apache.org/r/65571/diff/4/ > > > Testing > ------- > > `./mesos-tests` (See also last paragraph in description) > > > Thanks, > > Benno Evers > >
