-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65571/
-----------------------------------------------------------
(Updated March 22, 2018, 12:06 p.m.)
Review request for mesos, Andrei Budnik and Alexander Rukletsov.
Changes
-------
Reworded some log messages.
Bugs: MESOS-8550
https://issues.apache.org/jira/browse/MESOS-8550
Repository: mesos
Description
-------
The function `MasterDetector::detect()` returns a value of type
`Future<Option<MasterInfo>>`, which, according to its documentation,
can be `None` if an election occured and no master is elected.
However, the code in `Master::detected()` was only handling the
cases of a failed future or a valid `MasterInfo` object.
*NOTE*: This commit does not add a corresponding unit test, since
that would require starting a non-leading master. For the
ZooKeeperMasterDetector, this is blocked by MESOS-2976, and an API
change to make this possible with the StandaloneMasterDetector
would add a lot of complexity to the `cluster::Master::start()`
function for a feature that is unlikely to be re-used in any other
test.
Diffs (updated)
-----
src/master/master.cpp f0affa09dcf41b6a800e18105ad047bcffdfd3ec
Diff: https://reviews.apache.org/r/65571/diff/5/
Changes: https://reviews.apache.org/r/65571/diff/4-5/
Testing
-------
`./mesos-tests` (See also last paragraph in description)
Thanks,
Benno Evers
