----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65782/#review199390 -----------------------------------------------------------
src/master/validation.cpp Lines 218-219 (original), 218-222 (patched) <https://reviews.apache.org/r/65782/#comment279718> We need to validate `quoat_requests` is not empty somewhere, might as well be here? - Meng Zhu On Feb. 23, 2018, 2:43 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65782/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2018, 2:43 p.m.) > > > Review request for mesos, Michael Park and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > Note that this function does not currently validate the nested > messages, so this adheres to this for consistency. > > > Diffs > ----- > > src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6 > > > Diff: https://reviews.apache.org/r/65782/diff/1/ > > > Testing > ------- > > make check (test added in subsequent patch) > > > Thanks, > > Benjamin Mahler > >
