> On March 19, 2018, 9:41 a.m., Zhitao Li wrote: > > src/master/metrics.cpp > > Line 484 (original), 498 (patched) > > <https://reviews.apache.org/r/65300/diff/6/?file=1975215#file1975215line498> > > > > I'm not sure how this pattern can sustain in the long run as long as we > > keep adding new scheduler calls. > > > > For the long term, do you think we should have a pattern to > > automatically register a counter for every possible value of an enum (which > > should be obtainable from protobuf generated code of the type)? > > > > This is more of a long term ask.
Yeah, I chatted aboutt his with Greg a while ago, and we think that in the future (when MESOS-8533 is resolved) the implementation of this method should be similar to `Metrics::incrementTasksStates()`. - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65300/#review199424 ----------------------------------------------------------- On March 16, 2018, 12:57 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65300/ > ----------------------------------------------------------- > > (Updated March 16, 2018, 12:57 p.m.) > > > Review request for mesos, Greg Mann and Zhitao Li. > > > Bugs: MESOS-8184 > https://issues.apache.org/jira/browse/MESOS-8184 > > > Repository: mesos > > > Description > ------- > > Added master metrics for operation status acknowledgments handling. > > > Diffs > ----- > > docs/monitoring.md 0fba5cede553e2030260dcf8401d48e66e740270 > src/master/metrics.hpp b343904bd99defffe098077855d686b2d33c1fc1 > src/master/metrics.cpp b627372fd09b84aeda0b8e1b209d3bc0547faa39 > > > Diff: https://reviews.apache.org/r/65300/diff/6/ > > > Testing > ------- > > `make check` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
