----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65695/#review199539 -----------------------------------------------------------
src/launcher/default_executor.cpp Lines 1272 (patched) <https://reviews.apache.org/r/65695/#comment279825> space after semicolon please - Alexander Rukletsov On March 19, 2018, 4:36 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65695/ > ----------------------------------------------------------- > > (Updated March 19, 2018, 4:36 p.m.) > > > Review request for mesos, Alexander Rukletsov, Joseph Wu, Qian Zhang, and > Vinod Kone. > > > Bugs: MESOS-8530 > https://issues.apache.org/jira/browse/MESOS-8530 > > > Repository: mesos > > > Description > ------- > > The default executor transitions a task to `TASK_KILLING` and marks its > child container as being killed before posting a `KILL` call to the > agent. > > The executor ignores kill requests for containers that are marked as > being killed, and it doesn't remove this mark if the `KILL` call fails. > This means that it's possible for tasks to get stuck in a `TASK_KILLING` > state. > > This patch makes the default executor remove the killing mark if a > `KILL` call fails. That way a scheduler can retry a kill. > > > Diffs > ----- > > src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 > > > Diff: https://reviews.apache.org/r/65695/diff/3/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
