----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review199747 -----------------------------------------------------------
src/examples/CMakeLists.txt Lines 55-58 (patched) <https://reviews.apache.org/r/66163/#comment280192> This won't compile on non-Linux systems (as `test_csi_plugin.cpp` includes `linux/fs.hpp`). Hence this has to be guarded by an `if (LINUX)`. src/examples/CMakeLists.txt Lines 93-98 (patched) <https://reviews.apache.org/r/66163/#comment280193> Needs an additional `if (LINUX)` guard, as explained above. - Jan Schlicht On March 21, 2018, 12:47 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66163/ > ----------------------------------------------------------- > > (Updated March 21, 2018, 12:47 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-8698 > https://issues.apache.org/jira/browse/MESOS-8698 > > > Repository: mesos > > > Description > ------- > > This patch adds CMake rules for compiling necessary source code for > building storage local resource provider and related tests. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c > src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e > src/examples/CMakeLists.txt e85eed607715d2b3ee596c3c0b51f16682491900 > src/resource_provider/storage/CMakeLists.txt PRE-CREATION > src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 > > > Diff: https://reviews.apache.org/r/66163/diff/2/ > > > Testing > ------- > > `sudo make check` with CMake > > > Thanks, > > Chun-Hung Hsiao > >
