> On April 12, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote:
> > src/examples/CMakeLists.txt
> > Lines 55-59 (patched)
> > <https://reviews.apache.org/r/66163/diff/3/?file=1996905#file1996905line55>
> >
> >     What about non-Linux but not Windows platforms, e.g. MacOS and FreeBSD?

Saw in prior revision that it explicitly is only Linux because it includes 
`linux/fs.hpp`, maybe change the note that it's not non-Windows, but explicitly 
Linux specific.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66163/#review201017
-----------------------------------------------------------


On April 11, 2018, 10:15 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66163/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 10:15 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8698
>     https://issues.apache.org/jira/browse/MESOS-8698
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds CMake rules for compiling necessary source code for
> building storage local resource provider and related tests.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
>   src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
>   src/examples/CMakeLists.txt e85eed607715d2b3ee596c3c0b51f16682491900 
>   src/resource_provider/storage/CMakeLists.txt PRE-CREATION 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
> 
> 
> Diff: https://reviews.apache.org/r/66163/diff/3/
> 
> 
> Testing
> -------
> 
> `sudo make check` with CMake
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Reply via email to