----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66052/#review200052 -----------------------------------------------------------
include/mesos/master/master.proto Lines 187 (patched) <https://reviews.apache.org/r/66052/#comment280654> To keep with the existing pattern, in this file you should use 'slave_id'. You can use 'agent_id' in the V1 proto. The comment above should be changed to reference 'slave_id' as well. include/mesos/master/master.proto Lines 194 (patched) <https://reviews.apache.org/r/66052/#comment280657> s/size/the size/ include/mesos/master/master.proto Lines 196 (patched) <https://reviews.apache.org/r/66052/#comment280658> s/disk/disks/ Here and above. - Greg Mann On March 26, 2018, 4:54 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66052/ > ----------------------------------------------------------- > > (Updated March 26, 2018, 4:54 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > The same API could be used in the future to grow or shrink CSI volumes, > but currently only persistent volumes are supported. > > > Diffs > ----- > > include/mesos/master/master.proto aa63904a33290a3beda162bbc9f44b56ab04a1e7 > include/mesos/v1/master/master.proto > ddb28f96b2a3a439bb9a829995a9a3015f65ba43 > > > Diff: https://reviews.apache.org/r/66052/diff/4/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
