----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66318/#review200081 -----------------------------------------------------------
Patch looks great! Reviews applied: [66318] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 27, 2018, 4:27 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66318/ > ----------------------------------------------------------- > > (Updated March 27, 2018, 4:27 p.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. > > > Bugs: MESOS-8742 > https://issues.apache.org/jira/browse/MESOS-8742 > > > Repository: mesos > > > Description > ------- > > This patch adds descriptions to declare the following agent API calls > idempotent: > - `ADD_RESOURCE_PROVIDER_CONFIG` > - `UPDATE_RESOURCE_PROVIDER_CONFIG` > - `REMOVE_RESOURCE_PROVIDER_CONFIG` > > > Diffs > ----- > > include/mesos/agent/agent.proto adaccb3509fdfc1e7cac9482e93a91e83bc5625d > include/mesos/v1/agent/agent.proto 71352a79fe7d28d633a4badceafe18086c1e5ab7 > > > Diff: https://reviews.apache.org/r/66318/diff/1/ > > > Testing > ------- > > N/A > > The actual implementation will be in the next patch. > > > Thanks, > > Chun-Hung Hsiao > >
