----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66318/#review200089 -----------------------------------------------------------
include/mesos/agent/agent.proto Line 321 (original), 325 (patched) <https://reviews.apache.org/r/66318/#comment280736> nit: there are two spaces between "field" and "will" include/mesos/agent/agent.proto Line 327 (original), 331 (patched) <https://reviews.apache.org/r/66318/#comment280737> "Note that only..." I don't think this statement is true. I have e2e tests that add a provider and then update it. The provider DID NOT exist at agent startup. include/mesos/agent/agent.proto Line 332 (original), 338 (patched) <https://reviews.apache.org/r/66318/#comment280738> Maybe return 409 instead of 404 here, if the caller tries to update a config that does not exist? Because, you know, 404s can be misleading given the convo we had earlier... include/mesos/agent/agent.proto Lines 351 (patched) <https://reviews.apache.org/r/66318/#comment280739> "Note that only..." again, I have e2e tests that prove otherwise - James DeFelice On March 27, 2018, 11:27 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66318/ > ----------------------------------------------------------- > > (Updated March 27, 2018, 11:27 p.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. > > > Bugs: MESOS-8742 > https://issues.apache.org/jira/browse/MESOS-8742 > > > Repository: mesos > > > Description > ------- > > This patch adds descriptions to declare the following agent API calls > idempotent: > - `ADD_RESOURCE_PROVIDER_CONFIG` > - `UPDATE_RESOURCE_PROVIDER_CONFIG` > - `REMOVE_RESOURCE_PROVIDER_CONFIG` > > > Diffs > ----- > > include/mesos/agent/agent.proto adaccb3509fdfc1e7cac9482e93a91e83bc5625d > include/mesos/v1/agent/agent.proto 71352a79fe7d28d633a4badceafe18086c1e5ab7 > > > Diff: https://reviews.apache.org/r/66318/diff/1/ > > > Testing > ------- > > N/A > > The actual implementation will be in the next patch. > > > Thanks, > > Chun-Hung Hsiao > >
