----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66291/#review200119 -----------------------------------------------------------
src/launcher/default_executor.cpp Lines 1098-1102 (patched) <https://reviews.apache.org/r/66291/#comment280775> I think I also need to handle the case if a task run to success *before* reaching max duration. This is not a big issue for other built-in executors since they only run one task anyway, but we need to make sureJ: - other tasks in the group are not affected; - timer should be cancelled properly; - timer triggered after this task completed should not bring executor down accidentally. - Zhitao Li On March 26, 2018, 2:48 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66291/ > ----------------------------------------------------------- > > (Updated March 26, 2018, 2:48 p.m.) > > > Review request for mesos, Jason Lai and James Peach. > > > Bugs: MESOS-8725 > https://issues.apache.org/jira/browse/MESOS-8725 > > > Repository: mesos > > > Description > ------- > > Added support to max_duration in default executor. > > > Diffs > ----- > > src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 > > > Diff: https://reviews.apache.org/r/66291/diff/1/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
