> On March 27, 2018, 10:24 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 8054-8056 (patched) > > <https://reviews.apache.org/r/66050/diff/6/?file=1988973#file1988973line8057> > > > > Looks like we will now run `checkpointResources()` on resource provider > > resources which are contained in a speculative operation - this will > > violate a check in the agent: > > https://github.com/apache/mesos/blob/21e4b45b388d0b272236b1c58313569f8a1d1fc8/src/slave/slave.cpp#L4088
I don't think this is true since `needCheckpointing` filters out resources with providers: https://github.com/apache/mesos/blob/master/src/common/resources_utils.cpp#L30 - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review200071 ----------------------------------------------------------- On March 28, 2018, 6:26 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66050/ > ----------------------------------------------------------- > > (Updated March 28, 2018, 6:26 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > The new offer operations are implemented as non-speculative operations, > which means they cannot be chained with previous offer operations which > depend on results of each other. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080 > src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 > src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45 > src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf > src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d > src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > src/tests/reservation_tests.cpp 5570df2e0b208512d0a0a3079a180e1acfe08f3d > > > Diff: https://reviews.apache.org/r/66050/diff/7/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
