> On March 26, 2018, 5:37 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 8053-8059 (patched) > > <https://reviews.apache.org/r/66050/diff/5/?file=1985839#file1985839line8056> > > > > If we checkpoint resources after sending status updates, then say if > > the agent crashes before checkpointing, the master would have assumed that > > the operation is completed but the agent will recover to its old states. So > > let's checkpoint resources before sending status updates, as I suggested > > above.
That's already the case. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review199985 ----------------------------------------------------------- On March 28, 2018, 11:26 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66050/ > ----------------------------------------------------------- > > (Updated March 28, 2018, 11:26 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > The new offer operations are implemented as non-speculative operations, > which means they cannot be chained with previous offer operations which > depend on results of each other. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080 > src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 > src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45 > src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf > src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d > src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > src/tests/reservation_tests.cpp 5570df2e0b208512d0a0a3079a180e1acfe08f3d > > > Diff: https://reviews.apache.org/r/66050/diff/7/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
