----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/#review200609 -----------------------------------------------------------
Ship it! This looks good to me. I am wondering if we need more test coverage for insertion/deletion of roles implicit roles. Perhaps a TODO? src/tests/api_tests.cpp Lines 1072 (patched) <https://reviews.apache.org/r/65940/#comment281381> For completeness, can we check `roles(0)` as well? - Kapil Arya On April 5, 2018, 12:15 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65940/ > ----------------------------------------------------------- > > (Updated April 5, 2018, 12:15 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and > Michael Park. > > > Bugs: MESOS-8069 > https://issues.apache.org/jira/browse/MESOS-8069 > > > Repository: mesos > > > Description > ------- > > Added test validating hierarchical role accounting. > > > Diffs > ----- > > src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 > src/tests/role_tests.cpp a609ed27ef828ca82efc0d269669cda92e5f50a1 > > > Diff: https://reviews.apache.org/r/65940/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >