> On April 5, 2018, 5:01 p.m., James Peach wrote: > > I think we should just change all the usages of `pid` rather than renaming > > it to `pid_`.
Fixed. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/#review200605 ----------------------------------------------------------- On April 7, 2018, 5:50 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66481/ > ----------------------------------------------------------- > > (Updated April 7, 2018, 5:50 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and James Peach. > > > Repository: mesos > > > Description > ------- > > This avoids unix's assumption that `pid_t` is a signed integer (which is > not the case on Windows) and explicitly shows whether a pid has been > assigned from launching. > > We also changed argument name in `reaped` method to `_pid` to avoid > shadowing. > > > Diffs > ----- > > src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38 > > > Diff: https://reviews.apache.org/r/66481/diff/2/ > > > Testing > ------- > > `make` on Linux. > > > Thanks, > > Zhitao Li > >
