----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/#review200719 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/executor.cpp Line 983 (original), 983 (patched) <https://reviews.apache.org/r/66481/#comment281566> I think that `pid` should always have been set by the time we get there. Suggest `CHECK_SOME(pid)` or simply omitting this. - James Peach On April 8, 2018, 12:50 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66481/ > ----------------------------------------------------------- > > (Updated April 8, 2018, 12:50 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and James Peach. > > > Repository: mesos > > > Description > ------- > > This avoids unix's assumption that `pid_t` is a signed integer (which is > not the case on Windows) and explicitly shows whether a pid has been > assigned from launching. > > We also changed argument name in `reaped` method to `_pid` to avoid > shadowing. > > > Diffs > ----- > > src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38 > > > Diff: https://reviews.apache.org/r/66481/diff/2/ > > > Testing > ------- > > `make` on Linux. > > > Thanks, > > Zhitao Li > >
