> On April 9, 2018, 12:04 p.m., Greg Mann wrote:
> > src/master/http.cpp
> > Lines 959-973 (original), 959-969 (patched)
> > <https://reviews.apache.org/r/66464/diff/1/?file=1992581#file1992581line959>
> >
> >     Hmm I think we only want to execute this block for calls which will get 
> > a response body (i.e., for SUBSCRIBE and RECONCILE_OPERATIONS calls). The 
> > other calls do not require that the 'Accept' header be set.

Note that we don't require the `Accept` header to be set, if it isn't set, then 
the client accepts any content type, and JSON will be used.

We require that the client accepts JSON or Protobuf for all Master Operator API 
calls: 
https://github.com/apache/mesos/blob/be47e96e727f07758ff9b8ba1c23bbec2a489cd6/src/master/http.cpp#L692-L701

Why should it be different for the Scheduler API?


- Gaston


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66464/#review200680
-----------------------------------------------------------


On April 4, 2018, 5:47 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66464/
> -----------------------------------------------------------
> 
> (Updated April 4, 2018, 5:47 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented operation status reconciliation.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c 
> 
> 
> Diff: https://reviews.apache.org/r/66464/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> https://reviews.apache.org/r/66468/ adds new tests.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Reply via email to