> On April 9, 2018, 12:04 p.m., Greg Mann wrote: > > src/master/http.cpp > > Lines 5097 (patched) > > <https://reviews.apache.org/r/66464/diff/1/?file=1992581#file1992581line5102> > > > > s/reconcileOperations/std::move(reconcileOperations)/ > > Gaston Kleiman wrote: > Do you think that we need to use std::move to cast it as an rvalue? > > > It is already an rvalue per the method signature: > > ``` > Future<Response> Master::Http::reconcileOperations( > scheduler::Response::ReconcileOperations&& reconcileOperations, > ContentType contentType) const > ```
After writing a small program to test this, I can confirm that I was wrong. Good catch! Thanks =). - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/#review200680 ----------------------------------------------------------- On April 9, 2018, 2:30 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66464/ > ----------------------------------------------------------- > > (Updated April 9, 2018, 2:30 p.m.) > > > Review request for mesos and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Implemented operation status reconciliation. > > > Diffs > ----- > > src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 > src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 > src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 > > > Diff: https://reviews.apache.org/r/66464/diff/3/ > > > Testing > ------- > > `sudo bin/mesos-tests` on GNU/Linux > > https://reviews.apache.org/r/66468/ adds new tests. > > > Thanks, > > Gaston Kleiman > >
