> On April 10, 2018, 3:05 nachm., Jan Schlicht wrote: > > src/resource_provider/registrar.cpp > > Lines 97 (patched) > > <https://reviews.apache.org/r/66311/diff/2/?file=1994131#file1994131line97> > > > > `Registry` is in scope here and used without the namespace in other > > parts of this unit. Let's be consistent and drop the namespace here and > > below. > > Benjamin Bannier wrote: > See above. Dropping. > > Benjamin Bannier wrote: > Misread, reopening.
Fixed for a number `recover`s below as well. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200734 ----------------------------------------------------------- On April 11, 2018, 9:30 vorm., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66311/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 9:30 vorm.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8735 > https://issues.apache.org/jira/browse/MESOS-8735 > > > Repository: mesos > > > Description > ------- > > This patch adjusts the control flow of the resource provider manager > so that we can in the future make use of persisted resource provider > information. > > > Diffs > ----- > > src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a > src/resource_provider/registrar.hpp > 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 > src/resource_provider/registrar.cpp > 92ef9aecb1e93d10f46e53984391558f9901a60b > src/tests/resource_provider_manager_tests.cpp > c52541bf130ccf4795b989b53331176a64a097ea > > > Diff: https://reviews.apache.org/r/66311/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
