----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/#review200891 -----------------------------------------------------------
src/tests/default_executor_tests.cpp Lines 1427-1430 (patched) <https://reviews.apache.org/r/66538/#comment281808> Why do we need to launch the executor using reserved resources? This seems not relevant to the target of this test. I think we can just launch both the executor and the task with unreserved resources. src/tests/default_executor_tests.cpp Lines 1481-1485 (patched) <https://reviews.apache.org/r/66538/#comment281809> So we use this as a signal that the default executor has re-registered with the agent, right? But I think this `TASK_RUNNING` status update will actually be resent by the agent (rather than the executor) after the agent re-registered with the master and even before the executor re-registered with the agent. So I think it might not be used as such signal. - Qian Zhang On April 11, 2018, 7:41 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66538/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 7:41 a.m.) > > > Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-8772 > https://issues.apache.org/jira/browse/MESOS-8772 > > > Repository: mesos > > > Description > ------- > > Added unit test slave recovery for default executor tests. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 293dd20d882447401572835bd31e197faf76861b > > > Diff: https://reviews.apache.org/r/66538/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
