----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/#review200987 -----------------------------------------------------------
Fix it, then Ship it! src/tests/default_executor_tests.cpp Lines 1375 (patched) <https://reviews.apache.org/r/66538/#comment281921> We are now verifying agent recovery rather than executor re-register. So I think the comments should be something like: ``` // This test verifies that the agent could recover if the agent // metadata is checkpointed ``` - Qian Zhang On April 12, 2018, 4:40 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66538/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 4:40 a.m.) > > > Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-8772 > https://issues.apache.org/jira/browse/MESOS-8772 > > > Repository: mesos > > > Description > ------- > > Added unit test slave recovery for default executor tests. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 293dd20d882447401572835bd31e197faf76861b > > > Diff: https://reviews.apache.org/r/66538/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
