-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65585/#review200997
-----------------------------------------------------------




src/python/cli_new/bootstrap
Lines 120 (patched)
<https://reviews.apache.org/r/65585/#comment281927>

    This should be ${CURRDIR} too.
    There is no need to introduce a new ${BINDIR} here.


- Kevin Klues


On March 24, 2018, 11:39 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65585/
> -----------------------------------------------------------
> 
> (Updated March 24, 2018, 11:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Bugs: MESOS-8240
>     https://issues.apache.org/jira/browse/MESOS-8240
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Explains how to create the necessary virtual environment from
> anywhere and how to set up autocompletion in such case.
> 
> Also removes an unnecessary activation of the virtual environment
> in `mesos` and `mesos-cli-tests`.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/README.md 847141db9a1f9eb5c78b2d50367b599a5c72ce61 
>   src/python/cli_new/bin/mesos c5152a2ebf8704c804bb4f39e46580a512aecdea 
>   src/python/cli_new/bin/mesos-cli-tests 
> 07659e0b4551c2381828b256608d2c6ced3ae745 
>   src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a 
> 
> 
> Diff: https://reviews.apache.org/r/65585/diff/5/
> 
> 
> Testing
> -------
> 
> On Fedora 25:
> ```
> apache-mesos (MESOS-8240)$ cd src/python/cli_new/
> cli_new (MESOS-8240)$ ./bootstrap
> cli_new (MESOS-8240)$ source .virtualenv/activate
> (mesos-cli) cli_new (MESOS-8240)$ mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos <command> [<args>...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   task    Interacts with the tasks running in a Mesos cluster
> 
> See 'mesos help <command>' for more information on a specific command.
> (mesos-cli) cli_new (MESOS-8240)$ source deactivate
> cli_new (MESOS-8240)$ rm -rf .virtualenv/
> cli_new (MESOS-8240)$ cd ..
> python (MESOS-8240)$ VIRTUALENV_DIRECTORY=$(pwd)/.venv ./cli_new/bootstrap
> python (MESOS-8240)$ source 
> /home/agrillet/apache-mesos/src/python/.venv/bin/activate
> python (MESOS-8240)$ source 
> /home/agrillet/apache-mesos/src/python/.venv/bin/postactivate
> (mesos-cli) python (MESOS-8240)$ mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos <command> [<args>...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   task    Interacts with the tasks running in a Mesos cluster
> 
> See 'mesos help <command>' for more information on a specific command.
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Reply via email to