> On April 12, 2018, 8:19 p.m., Till Toenshoff wrote: > > src/master/validation.cpp > > Lines 532 (patched) > > <https://reviews.apache.org/r/66229/diff/4/?file=1996013#file1996013line532> > > > > s/is/are/ > > > > How do we make sure the role is "valid" - isn't that implicit when it > > was contained in the framework roles?
Updated the comment to reflect that we are validating "suppressed" roles. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/#review201053 ----------------------------------------------------------- On April 12, 2018, 9:38 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66229/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 9:38 p.m.) > > > Review request for mesos, Benjamin Mahler and Till Toenshoff. > > > Bugs: MESOS-7258 > https://issues.apache.org/jira/browse/MESOS-7258 > > > Repository: mesos > > > Description > ------- > > Implemented UPDATE_FRAMEWORK call. > > > Diffs > ----- > > src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 > src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 > src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 > src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 > src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb > src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf > src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d > > > Diff: https://reviews.apache.org/r/66229/diff/5/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
