----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review201085 -----------------------------------------------------------
Patch looks great! Reviews applied: [66481, 66258, 66591, 66259, 66260, 66283, 66284, 66291, 66293] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 8, 2018, 12:54 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66293/ > ----------------------------------------------------------- > > (Updated April 8, 2018, 12:54 a.m.) > > > Review request for mesos, Jason Lai and James Peach. > > > Bugs: MESOS-8725 > https://issues.apache.org/jira/browse/MESOS-8725 > > > Repository: mesos > > > Description > ------- > > Tested default executor support of `max_completion_time`. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 293dd20d882447401572835bd31e197faf76861b > > > Diff: https://reviews.apache.org/r/66293/diff/4/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >