----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201106 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 4965-4966 (patched) <https://reviews.apache.org/r/66568/#comment282071> Could you create a JIRA for the speculative -> non-speculative change and mention the ticket here, and below? src/master/master.cpp Lines 4967 (patched) <https://reviews.apache.org/r/66568/#comment282072> Suggestion: this is a very cheap piece of validation to perform, so I would probably put it near the top of this operation's `switch` case. Here and below for SHRINK_VOLUME as well. - Greg Mann On April 11, 2018, 9:18 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66568/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 9:18 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > These two operations are intended to be non-speculative eventually but > are implemented as speculative right now. To avoid frameworks opt-in to > dangerous behavior, we require that accept can only container one > `GROW_VOLUME` or `SHRINK_VOLUME` and no other operations. > > > Diffs > ----- > > src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 > > > Diff: https://reviews.apache.org/r/66568/diff/1/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
