> On April 17, 2018, 12:04 p.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 4525 (patched) > > <https://reviews.apache.org/r/66568/diff/2/?file=2004959#file2004959line4525> > > > > I'm not sure about this. Would `REASON_TASK_INVALID` be more > > appropriate?
I honest don't think there is an appropriate reason right now. `REASON_TASK_INVALID` would mean payload of task is incorrect, which is also not the case here. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201342 ----------------------------------------------------------- On April 17, 2018, 10 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66568/ > ----------------------------------------------------------- > > (Updated April 17, 2018, 10 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > These two operations are intended to be non-speculative eventually but > are implemented as speculative right now. To avoid frameworks opt-in to > dangerous behavior, we require that accept can only contain one > `GROW_VOLUME` or `SHRINK_VOLUME` and no other operations. > > This is implemented by reuse existing code which already drops `LAUNCH` > or `LAUNCH_GROUP` with proper reason and message. > > > Diffs > ----- > > src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a > > > Diff: https://reviews.apache.org/r/66568/diff/2/ > > > Testing > ------- > > Behavior tested in https://reviews.apache.org/r/66569/. > > > Thanks, > > Zhitao Li > >
