> On April 4, 2018, 5:50 a.m., Gilbert Song wrote: > > src/slave/slave.cpp > > Lines 6743 (patched) > > <https://reviews.apache.org/r/66039/diff/2/?file=1974374#file1974374line6743> > > > > I would leave this to @andschwa since I suspect we could have a windows > > implementation together.
andschwa left some comments in 66308, and they are all solved. - fei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66039/#review200429 ----------------------------------------------------------- On April 14, 2018, 11:02 a.m., fei long wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66039/ > ----------------------------------------------------------- > > (Updated April 14, 2018, 11:02 a.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-8665 > https://issues.apache.org/jira/browse/MESOS-8665 > > > Repository: mesos > > > Description > ------- > > Check both disk and inode usage when slaves schedule gc. > > > Diffs > ----- > > src/slave/slave.hpp d00c7b2e2466fd1de71e9e55343a27d3808bde3e > src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 > src/tests/gc_tests.cpp 619ed22edd9b3909ea24cdcbf62c354420a8d031 > > > Diff: https://reviews.apache.org/r/66039/diff/3/ > > > Testing > ------- > > No new tests are added and all "make check" tests are passed. > > > Thanks, > > fei long > >
