-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66637/#review201225
-----------------------------------------------------------




src/tests/containerizer/docker_containerizer_tests.cpp
Lines 107-111 (patched)
<https://reviews.apache.org/r/66637/#comment282357>

    Nit:
    
    I'd do:
    
    ```
    ContainerInfo::DockerInfo* dockerInfo = containerInfo.mutable_docker();
    dockerInfo->set_image(imageName);
    
    return containerInfo;
    ```



src/tests/containerizer/docker_containerizer_tests.cpp
Line 378 (original)
<https://reviews.apache.org/r/66637/#comment282358>

    The default networking is `HOST`, so this line shouldn't be removed.


- Gaston Kleiman


On April 16, 2018, 9:52 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66637/
> -----------------------------------------------------------
> 
> (Updated April 16, 2018, 9:52 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gaston Kleiman, Greg Mann, and 
> Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Docker containerizer tests all create a Docker `ContainerInfo`.
> We can reduce the amount of copy/paste boilerplate by adding a
> simple helper function to create a `ContainerInfo` with a Docker
> image.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 847258daadf3c37d9071151616b18fc79d850ce8 
> 
> 
> Diff: https://reviews.apache.org/r/66637/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Reply via email to